]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
tty: serial: samsung_tty: drop unused argument to irq handlers
authorAndré Draszik <andre.draszik@linaro.org>
Thu, 8 Aug 2024 08:11:51 +0000 (09:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Aug 2024 06:22:49 +0000 (08:22 +0200)
The 'irq' argument is not used in any of the callees, we can just drop
it and simplify the code.

No functional changes.

Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Signed-off-by: André Draszik <andre.draszik@linaro.org>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20240808-samsung-tty-cleanup-v3-1-494412f49f4b@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/samsung_tty.c

index dc35eb77d2ef34147b288cb264ece5eba00d7c63..1c6d0ffe564967828f214adde869fe72909dd9fd 100644 (file)
@@ -855,7 +855,7 @@ static irqreturn_t s3c24xx_serial_rx_chars_pio(void *dev_id)
        return IRQ_HANDLED;
 }
 
-static irqreturn_t s3c24xx_serial_rx_irq(int irq, void *dev_id)
+static irqreturn_t s3c24xx_serial_rx_irq(void *dev_id)
 {
        struct s3c24xx_uart_port *ourport = dev_id;
 
@@ -928,7 +928,7 @@ static void s3c24xx_serial_tx_chars(struct s3c24xx_uart_port *ourport)
                s3c24xx_serial_stop_tx(port);
 }
 
-static irqreturn_t s3c24xx_serial_tx_irq(int irq, void *id)
+static irqreturn_t s3c24xx_serial_tx_irq(void *id)
 {
        struct s3c24xx_uart_port *ourport = id;
        struct uart_port *port = &ourport->port;
@@ -950,11 +950,11 @@ static irqreturn_t s3c64xx_serial_handle_irq(int irq, void *id)
        irqreturn_t ret = IRQ_HANDLED;
 
        if (pend & S3C64XX_UINTM_RXD_MSK) {
-               ret = s3c24xx_serial_rx_irq(irq, id);
+               ret = s3c24xx_serial_rx_irq(id);
                wr_regl(port, S3C64XX_UINTP, S3C64XX_UINTM_RXD_MSK);
        }
        if (pend & S3C64XX_UINTM_TXD_MSK) {
-               ret = s3c24xx_serial_tx_irq(irq, id);
+               ret = s3c24xx_serial_tx_irq(id);
                wr_regl(port, S3C64XX_UINTP, S3C64XX_UINTM_TXD_MSK);
        }
        return ret;
@@ -971,11 +971,11 @@ static irqreturn_t apple_serial_handle_irq(int irq, void *id)
        if (pend & (APPLE_S5L_UTRSTAT_RXTHRESH | APPLE_S5L_UTRSTAT_RXTO)) {
                wr_regl(port, S3C2410_UTRSTAT,
                        APPLE_S5L_UTRSTAT_RXTHRESH | APPLE_S5L_UTRSTAT_RXTO);
-               ret = s3c24xx_serial_rx_irq(irq, id);
+               ret = s3c24xx_serial_rx_irq(id);
        }
        if (pend & APPLE_S5L_UTRSTAT_TXTHRESH) {
                wr_regl(port, S3C2410_UTRSTAT, APPLE_S5L_UTRSTAT_TXTHRESH);
-               ret = s3c24xx_serial_tx_irq(irq, id);
+               ret = s3c24xx_serial_tx_irq(id);
        }
 
        return ret;