]> www.infradead.org Git - linux.git/commitdiff
drm/amd/display: temp w/a for dGPU to enter idle optimizations
authorAurabindo Pillai <aurabindo.pillai@amd.com>
Tue, 1 Oct 2024 22:03:02 +0000 (18:03 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 22 Oct 2024 22:10:55 +0000 (18:10 -0400)
[Why&How]
vblank immediate disable currently does not work for all asics. On
DCN401, the vblank interrupts never stop coming, and hence we never
get a chance to trigger idle optimizations.

Add a workaround to enable immediate disable only on APUs for now. This
adds a 2-frame delay for triggering idle optimization, which is a
negligible overhead.

Fixes: 58a261bfc967 ("drm/amd/display: use a more lax vblank enable policy for older ASICs")
Fixes: e45b6716de4b ("drm/amd/display: use a more lax vblank enable policy for DCN35+")
Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Wayne Lin <wayne.lin@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 9b47278cec98e9894adf39229e91aaf4ab9140c5)
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index 6b5e2206e6879d9c5c559da0bcf7354ede41134e..13421a58210d5acebdf9d49546003e821cbd9e64 100644 (file)
@@ -8374,7 +8374,8 @@ static void manage_dm_interrupts(struct amdgpu_device *adev,
                if (amdgpu_ip_version(adev, DCE_HWIP, 0) <
                    IP_VERSION(3, 5, 0) ||
                    acrtc_state->stream->link->psr_settings.psr_version <
-                   DC_PSR_VERSION_UNSUPPORTED) {
+                   DC_PSR_VERSION_UNSUPPORTED ||
+                   !(adev->flags & AMD_IS_APU)) {
                        timing = &acrtc_state->stream->timing;
 
                        /* at least 2 frames */