]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
arm64: dts: socfpga: agilex: move firmware out of soc node
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sat, 9 Dec 2023 17:30:42 +0000 (18:30 +0100)
committerDinh Nguyen <dinguyen@kernel.org>
Thu, 4 Jan 2024 00:10:40 +0000 (18:10 -0600)
The "soc" node is supposed to have only MMIO children, so move the
firmware/svc node to top level to fix dtc W=1 warnings like:

  socfpga_agilex.dtsi:663.12-673.5: Warning (simple_bus_reg): /soc@0/firmware: missing or empty reg/ranges property

The node should still be instantiated by drivers/of/platform.c, just
like in all other platforms.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi

index 77d03caea25b6b0a56b22247676e0e580e5189c4..8792291a0175f92b14bc2440ce74a372b578ab3a 100644 (file)
                };
        };
 
+       firmware {
+               svc {
+                       compatible = "intel,agilex-svc";
+                       method = "smc";
+                       memory-region = <&service_reserved>;
+
+                       fpga_mgr: fpga-mgr {
+                               compatible = "intel,agilex-soc-fpga-mgr";
+                       };
+               };
+       };
+
        fpga-region {
                compatible = "fpga-region";
                #address-cells = <0x2>;
 
                        status = "disabled";
                };
-
-               firmware {
-                       svc {
-                               compatible = "intel,agilex-svc";
-                               method = "smc";
-                               memory-region = <&service_reserved>;
-
-                               fpga_mgr: fpga-mgr {
-                                       compatible = "intel,agilex-soc-fpga-mgr";
-                               };
-                       };
-               };
        };
 };