aiaiai-checker: ignore debugging output from spatch

spatch is a great tool, but it is still not very stable and crashes sometimes,
in which case it prints a lot of debugging stuff to stderr, which we do not
want in out logs. Normal warnings go to stdout. Therefore, ignore stderr output
of spatch.

And switch to the new style options format instead of using the old style.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

diff --git a/helpers/aiaiai-checker b/helpers/aiaiai-checker
index 6aa8e79a410e2a39c104f8757f3028ec0f57b5cc..b265b45e09b56da08966b2cab3633215e3d4f76a 100755 (executable)
--- a/helpers/aiaiai-checker
+++ b/helpers/aiaiai-checker
@@ -75,13 +75,17 @@ run_coccinelle()
                # Coccinelle is not stable enough so far and dies because of
                # internal issues sometimes or just never stops. So we specify
                # a timeout as well as ignore its error code.
-               flags="-D report -no_show_diff -very_quiet -no_includes -include_headers -timeout 60"
+               flags="-D report --no-show-diff --very-quiet --no-includes --include-headers --timeout 60"
 
                # Run coccinelle for each semantic patch in parallel. This may load the
                # system too heavily, though. We use aiaiai-locker to make sure
                # we have non-scrambled output.
+               #
+               # Also redirect stderr to /dev/null since it crashes sometimes
+               # and prints different kind of uninteresting debugging
+               # information to stderr
                aiaiai-locker -s -l "$tmpdir/lockfile" -c \
-                       "spatch $flags -sp_file $spatch $file_to_check" ||: &
+                       "spatch $flags --sp-file $spatch $file_to_check" 2> /dev/null ||: &
                pids="$pids $!"
        done