backlight: gpio: Simplify with dev_err_probe()

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Link: https://lore.kernel.org/r/20240305-backlight-probe-v2-1-609b0cf24bde@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
index d28c30b2a35d23b4d66cc97258f709b4f2b22aa1..e0c8c2a3f5dc2bb6b2a59d1406ae17ad0f54f2ec 100644 (file)
--- a/drivers/video/backlight/gpio_backlight.c
+++ b/drivers/video/backlight/gpio_backlight.c
@@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *pdev)
        def_value = device_property_read_bool(dev, "default-on");
 
        gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS);
-       if (IS_ERR(gbl->gpiod)) {
-               ret = PTR_ERR(gbl->gpiod);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(dev,
-                               "Error: The gpios parameter is missing or invalid.\n");
-               return ret;
-       }
+       if (IS_ERR(gbl->gpiod))
+               return dev_err_probe(dev, PTR_ERR(gbl->gpiod),
+                                    "The gpios parameter is missing or invalid\n");
 
        memset(&props, 0, sizeof(props));
        props.type = BACKLIGHT_RAW;