]> www.infradead.org Git - users/sagi/nvme-cli.git/commitdiff
nvme: fix log-id data type and remove unnecessary log-id validtion
authorGollu Appalanaidu <anaidu.gollu@samsung.com>
Tue, 2 Feb 2021 17:06:25 +0000 (22:36 +0530)
committerKeith Busch <kbusch@kernel.org>
Tue, 2 Feb 2021 18:40:05 +0000 (11:40 -0700)
Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
nvme.c

diff --git a/nvme.c b/nvme.c
index 5a11d70e117c3ea924f8755a4750f74e691c178a..f6de23a02366a3f6f0d63d1e5aab320d80a479d6 100644 (file)
--- a/nvme.c
+++ b/nvme.c
@@ -1024,7 +1024,7 @@ static int get_log(int argc, char **argv, struct command *cmd, struct plugin *pl
 
        struct config {
                __u32 namespace_id;
-               __u32 log_id;
+               __u log_id;
                __u32 log_len;
                __u32 aen;
                __u64 lpo;
@@ -1036,7 +1036,7 @@ static int get_log(int argc, char **argv, struct command *cmd, struct plugin *pl
 
        struct config cfg = {
                .namespace_id = NVME_NSID_ALL,
-               .log_id       = 0xffffffff,
+               .log_id       = 0xff,
                .log_len      = 0,
                .lpo          = NVME_NO_LOG_LPO,
                .lsp          = NVME_NO_LOG_LSP,
@@ -1066,12 +1066,6 @@ static int get_log(int argc, char **argv, struct command *cmd, struct plugin *pl
                cfg.log_id = (cfg.aen >> 16) & 0xff;
        }
 
-       if (cfg.log_id > 0xff) {
-               fprintf(stderr, "Invalid log identifier: %d. Valid range: 0-255\n", cfg.log_id);
-               err = -EINVAL;
-               goto close_fd;
-       }
-
        if (!cfg.log_len) {
                fprintf(stderr, "non-zero log-len is required param\n");
                err = -EINVAL;