greybus: bundle: use kstrdup() for state file

The kernfs code guarantees we'll get a NUL-terminated buffer.
Use kstrdup() rather than kzalloc() + memcpy() in state_store()
making it slightly clearer what we're doing.  This has the added
benefit of guaranteeing that the stored string has no NUL character
inside it.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>

diff --git a/drivers/staging/greybus/bundle.c b/drivers/staging/greybus/bundle.c
index e7b2199f39b4d6d7886bd3e6ddcea771128b7681..2047e173ebd922c932bdc1934033e9a46eac57d6 100644 (file)
--- a/drivers/staging/greybus/bundle.c
+++ b/drivers/staging/greybus/bundle.c
@@ -48,12 +48,10 @@ static ssize_t state_store(struct device *dev, struct device_attribute *attr,
        struct gb_bundle *bundle = to_gb_bundle(dev);
 
        kfree(bundle->state);
-       bundle->state = kzalloc(size + 1, GFP_KERNEL);
+       bundle->state = kstrdup(buf, GFP_KERNEL);
        if (!bundle->state)
                return -ENOMEM;
 
-       memcpy(bundle->state, buf, size);
-
        /* Tell userspace that the file contents changed */
        sysfs_notify(&bundle->dev.kobj, NULL, "state");