gpio: wcove: Request IRQ after all initialisation done

There is logically better to request IRQ when we initialise all structures.
Align the driver with the rest on the same matter.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200728125504.27786-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c
index 135645096575cce1dad3f0b6dbf4a9f95c952dc7..b5fbba5a783af2402a3fd3a86e3fc8f1a127ac92 100644 (file)
--- a/drivers/gpio/gpio-wcove.c
+++ b/drivers/gpio/gpio-wcove.c
@@ -449,13 +449,6 @@ static int wcove_gpio_probe(struct platform_device *pdev)
                return virq;
        }
 
-       ret = devm_request_threaded_irq(dev, virq, NULL,
-               wcove_gpio_irq_handler, IRQF_ONESHOT, pdev->name, wg);
-       if (ret) {
-               dev_err(dev, "Failed to request irq %d\n", virq);
-               return ret;
-       }
-
        girq = &wg->chip.irq;
        girq->chip = &wcove_irqchip;
        /* This will let us handle the parent IRQ in the driver */
@@ -466,6 +459,13 @@ static int wcove_gpio_probe(struct platform_device *pdev)
        girq->handler = handle_simple_irq;
        girq->threaded = true;
 
+       ret = devm_request_threaded_irq(dev, virq, NULL, wcove_gpio_irq_handler,
+                                       IRQF_ONESHOT, pdev->name, wg);
+       if (ret) {
+               dev_err(dev, "Failed to request irq %d\n", virq);
+               return ret;
+       }
+
        ret = devm_gpiochip_add_data(dev, &wg->chip, wg);
        if (ret) {
                dev_err(dev, "Failed to add gpiochip: %d\n", ret);