wifi: mac80211: move radar detect work to wiphy work

Move the radar detect work to wiphy work in order
to lock the wiphy for it without doing it manually.

Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
index 0d9aff6a4fc84aeeac7a0636199f475bb20c15e1..9be569ade9f7b1a77754166a7a874879c90f78ad 100644 (file)
--- a/net/mac80211/ieee80211_i.h
+++ b/net/mac80211/ieee80211_i.h
@@ -1412,7 +1412,7 @@ struct ieee80211_local {
        /* wowlan is enabled -- don't reconfig on resume */
        bool wowlan;
 
-       struct work_struct radar_detected_work;
+       struct wiphy_work radar_detected_work;
 
        /* number of RX chains the hardware has */
        u8 rx_chains;
@@ -2571,7 +2571,8 @@ bool ieee80211_is_radar_required(struct ieee80211_local *local);
 
 void ieee80211_dfs_cac_timer_work(struct wiphy *wiphy, struct wiphy_work *work);
 void ieee80211_dfs_cac_cancel(struct ieee80211_local *local);
-void ieee80211_dfs_radar_detected_work(struct work_struct *work);
+void ieee80211_dfs_radar_detected_work(struct wiphy *wiphy,
+                                      struct wiphy_work *work);
 int ieee80211_send_action_csa(struct ieee80211_sub_if_data *sdata,
                              struct cfg80211_csa_settings *csa_settings);
 

diff --git a/net/mac80211/main.c b/net/mac80211/main.c
index aeb21cfe789ae94ed99a0f20b80b5cc369f9475f..b3c3b031b5b8c3594e5d6c7c41dac3e76ac10467 100644 (file)
--- a/net/mac80211/main.c
+++ b/net/mac80211/main.c
@@ -338,7 +338,6 @@ static void ieee80211_restart_work(struct work_struct *work)
        /* wait for scan work complete */
        flush_workqueue(local->workqueue);
        flush_work(&local->sched_scan_stopped_work);
-       flush_work(&local->radar_detected_work);
 
        rtnl_lock();
        /* we might do interface manipulations, so need both */
@@ -814,8 +813,8 @@ struct ieee80211_hw *ieee80211_alloc_hw_nm(size_t priv_data_len,
 
        INIT_WORK(&local->restart_work, ieee80211_restart_work);
 
-       INIT_WORK(&local->radar_detected_work,
-                 ieee80211_dfs_radar_detected_work);
+       wiphy_work_init(&local->radar_detected_work,
+                       ieee80211_dfs_radar_detected_work);
 
        INIT_WORK(&local->reconfig_filter, ieee80211_reconfig_filter);
        local->smps_mode = IEEE80211_SMPS_OFF;
@@ -1483,13 +1482,15 @@ void ieee80211_unregister_hw(struct ieee80211_hw *hw)
         */
        ieee80211_remove_interfaces(local);
 
+       wiphy_lock(local->hw.wiphy);
+       wiphy_work_cancel(local->hw.wiphy, &local->radar_detected_work);
+       wiphy_unlock(local->hw.wiphy);
        rtnl_unlock();
 
        cancel_delayed_work_sync(&local->roc_work);
        cancel_work_sync(&local->restart_work);
        cancel_work_sync(&local->reconfig_filter);
        flush_work(&local->sched_scan_stopped_work);
-       flush_work(&local->radar_detected_work);
 
        ieee80211_clear_tx_pending(local);
        rate_control_deinitialize(local);

diff --git a/net/mac80211/util.c b/net/mac80211/util.c
index ff99aee46656502364de85d269faedcfc5416261..701f5b4eadaecc81b4d00173ffc65fc96109b217 100644 (file)
--- a/net/mac80211/util.c
+++ b/net/mac80211/util.c
@@ -4358,7 +4358,8 @@ void ieee80211_dfs_cac_cancel(struct ieee80211_local *local)
        mutex_unlock(&local->mtx);
 }
 
-void ieee80211_dfs_radar_detected_work(struct work_struct *work)
+void ieee80211_dfs_radar_detected_work(struct wiphy *wiphy,
+                                      struct wiphy_work *work)
 {
        struct ieee80211_local *local =
                container_of(work, struct ieee80211_local, radar_detected_work);
@@ -4376,9 +4377,7 @@ void ieee80211_dfs_radar_detected_work(struct work_struct *work)
        }
        mutex_unlock(&local->chanctx_mtx);
 
-       wiphy_lock(local->hw.wiphy);
        ieee80211_dfs_cac_cancel(local);
-       wiphy_unlock(local->hw.wiphy);
 
        if (num_chanctx > 1)
                /* XXX: multi-channel is not supported yet */
@@ -4393,7 +4392,7 @@ void ieee80211_radar_detected(struct ieee80211_hw *hw)
 
        trace_api_radar_detected(local);
 
-       schedule_work(&local->radar_detected_work);
+       wiphy_work_queue(hw->wiphy, &local->radar_detected_work);
 }
 EXPORT_SYMBOL(ieee80211_radar_detected);