]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
s390/qeth: fix off-by-one in RX copybreak check
authorJulian Wiedmann <jwi@linux.ibm.com>
Thu, 20 Feb 2020 14:54:56 +0000 (15:54 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Mar 2020 15:45:19 +0000 (16:45 +0100)
commit 54a61fbc020fd2e305680871c453abcf7fc0339b upstream.

The RX copybreak is intended as the _max_ value where the frame's data
should be copied. So for frame_len == copybreak, don't build an SG skb.

Fixes: 4a71df50047f ("qeth: new qeth device driver")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/s390/net/qeth_core_main.c

index 29facb9136715638719bb271f86888ec120616f6..10edfd6fc930292fb80d3b8f7011149d7122c032 100644 (file)
@@ -5142,7 +5142,7 @@ next_packet:
        }
 
        use_rx_sg = (card->options.cq == QETH_CQ_ENABLED) ||
-                   ((skb_len >= card->options.rx_sg_cb) &&
+                   (skb_len > card->options.rx_sg_cb &&
                     !atomic_read(&card->force_alloc_skb) &&
                     !IS_OSN(card));