ASoC: fsl: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 09b2967befd9668b77a16dcb262bbf045e364a50..fa862af25c1a35792521a15ef7f423e8da29e345 100644 (file)
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -1582,9 +1582,7 @@ static int fsl_ssi_probe(struct platform_device *pdev)
                }
        }
 
-       ret = fsl_ssi_debugfs_create(&ssi->dbg_stats, dev);
-       if (ret)
-               goto error_asoc_register;
+       fsl_ssi_debugfs_create(&ssi->dbg_stats, dev);
 
        /* Initially configures SSI registers */
        fsl_ssi_hw_init(ssi);

diff --git a/sound/soc/fsl/fsl_ssi.h b/sound/soc/fsl/fsl_ssi.h
index 0bdda608d4146fc000c499b2ced387287762df58..db57cad80449fa7c2092d32588bd80b02386545d 100644 (file)
--- a/sound/soc/fsl/fsl_ssi.h
+++ b/sound/soc/fsl/fsl_ssi.h
@@ -270,7 +270,6 @@ struct device;
 
 struct fsl_ssi_dbg {
        struct dentry *dbg_dir;
-       struct dentry *dbg_stats;
 
        struct {
                unsigned int rfrc;
@@ -299,7 +298,7 @@ struct fsl_ssi_dbg {
 
 void fsl_ssi_dbg_isr(struct fsl_ssi_dbg *ssi_dbg, u32 sisr);
 
-int fsl_ssi_debugfs_create(struct fsl_ssi_dbg *ssi_dbg, struct device *dev);
+void fsl_ssi_debugfs_create(struct fsl_ssi_dbg *ssi_dbg, struct device *dev);
 
 void fsl_ssi_debugfs_remove(struct fsl_ssi_dbg *ssi_dbg);
 
@@ -312,10 +311,9 @@ static inline void fsl_ssi_dbg_isr(struct fsl_ssi_dbg *stats, u32 sisr)
 {
 }
 
-static inline int fsl_ssi_debugfs_create(struct fsl_ssi_dbg *ssi_dbg,
-                                        struct device *dev)
+static inline void fsl_ssi_debugfs_create(struct fsl_ssi_dbg *ssi_dbg,
+                                         struct device *dev)
 {
-       return 0;
 }
 
 static inline void fsl_ssi_debugfs_remove(struct fsl_ssi_dbg *ssi_dbg)

diff --git a/sound/soc/fsl/fsl_ssi_dbg.c b/sound/soc/fsl/fsl_ssi_dbg.c
index 6f6294149476adddc935ca325fd22c5b905c3824..2a20ee23dc52d19e62b2544df73d8cf755ee3d69 100644 (file)
--- a/sound/soc/fsl/fsl_ssi_dbg.c
+++ b/sound/soc/fsl/fsl_ssi_dbg.c
@@ -126,25 +126,15 @@ static int fsl_ssi_stats_show(struct seq_file *s, void *unused)
 
 DEFINE_SHOW_ATTRIBUTE(fsl_ssi_stats);
 
-int fsl_ssi_debugfs_create(struct fsl_ssi_dbg *ssi_dbg, struct device *dev)
+void fsl_ssi_debugfs_create(struct fsl_ssi_dbg *ssi_dbg, struct device *dev)
 {
        ssi_dbg->dbg_dir = debugfs_create_dir(dev_name(dev), NULL);
-       if (!ssi_dbg->dbg_dir)
-               return -ENOMEM;
 
-       ssi_dbg->dbg_stats = debugfs_create_file("stats", 0444,
-                                                ssi_dbg->dbg_dir, ssi_dbg,
-                                                &fsl_ssi_stats_fops);
-       if (!ssi_dbg->dbg_stats) {
-               debugfs_remove(ssi_dbg->dbg_dir);
-               return -ENOMEM;
-       }
-
-       return 0;
+       debugfs_create_file("stats", 0444, ssi_dbg->dbg_dir, ssi_dbg,
+                           &fsl_ssi_stats_fops);
 }
 
 void fsl_ssi_debugfs_remove(struct fsl_ssi_dbg *ssi_dbg)
 {
-       debugfs_remove(ssi_dbg->dbg_stats);
-       debugfs_remove(ssi_dbg->dbg_dir);
+       debugfs_remove_recursive(ssi_dbg->dbg_dir);
 }

diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c
index 04e59e66711d0974e4921ee69d3a24b6b1404da7..b2351cd33b0f5781617321b45847d68de2bcea68 100644 (file)
--- a/sound/soc/fsl/imx-audmux.c
+++ b/sound/soc/fsl/imx-audmux.c
@@ -141,17 +141,11 @@ static void audmux_debugfs_init(void)
        char buf[20];
 
        audmux_debugfs_root = debugfs_create_dir("audmux", NULL);
-       if (!audmux_debugfs_root) {
-               pr_warning("Failed to create AUDMUX debugfs root\n");
-               return;
-       }
 
        for (i = 0; i < MX31_AUDMUX_PORT7_SSI_PINS_7 + 1; i++) {
                snprintf(buf, sizeof(buf), "ssi%lu", i);
-               if (!debugfs_create_file(buf, 0444, audmux_debugfs_root,
-                                        (void *)i, &audmux_debugfs_fops))
-                       pr_warning("Failed to create AUDMUX port %lu debugfs file\n",
-                                  i);
+               debugfs_create_file(buf, 0444, audmux_debugfs_root,
+                                   (void *)i, &audmux_debugfs_fops);
        }
 }