]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ASoC: rt722-sdca: Remove logically deadcode in rt722-sdca.c
authorEverest K.C <everestkc@everestkc.com.np>
Thu, 10 Oct 2024 17:57:54 +0000 (11:57 -0600)
committerMark Brown <broonie@kernel.org>
Fri, 11 Oct 2024 12:59:47 +0000 (13:59 +0100)
As the same condition was checked in inner and outer if statements.
The code never reaches the inner else statement.
Fix this by removing the logically dead inner else statement.

Fixes: 7f5d6036ca00 ("ASoC: rt722-sdca: Add RT722 SDCA driver")
Reported-by: Shuah Khan <skhan@linuxfoundation.org>
Closes: https://lore.kernel.org/all/e44527e8-b7c6-4712-97a6-d54f02ad2dc9@linuxfoundation.org/
Signed-off-by: Everest K.C. <everestkc@everestkc.com.np>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Link: https://patch.msgid.link/20241010175755.5278-1-everestkc@everestkc.com.np
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt722-sdca.c

index e5bd9ef812de13378801d82356b54ee4144f219a..f9f7512ca360870cbdadf595cdad8d8c3015353f 100644 (file)
@@ -607,12 +607,8 @@ static int rt722_sdca_dmic_set_gain_get(struct snd_kcontrol *kcontrol,
 
                if (!adc_vol_flag) /* boost gain */
                        ctl = regvalue / boost_step;
-               else { /* ADC gain */
-                       if (adc_vol_flag)
-                               ctl = p->max - (((vol_max - regvalue) & 0xffff) / interval_offset);
-                       else
-                               ctl = p->max - (((0 - regvalue) & 0xffff) / interval_offset);
-               }
+               else /* ADC gain */
+                       ctl = p->max - (((vol_max - regvalue) & 0xffff) / interval_offset);
 
                ucontrol->value.integer.value[i] = ctl;
        }