]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/xe: Remove double pageflip
authorMaarten Lankhorst <dev@lankhorst.se>
Tue, 10 Dec 2024 08:31:02 +0000 (09:31 +0100)
committerMaarten Lankhorst <dev@lankhorst.se>
Tue, 21 Jan 2025 14:02:34 +0000 (15:02 +0100)
This is already handled below in the code by fixup_initial_plane_config.

Fixes: a8153627520a ("drm/i915: Try to relocate the BIOS fb to the start of ggtt")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241210083111.230484-3-dev@lankhorst.se
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
drivers/gpu/drm/xe/display/xe_plane_initial.c

index 2eb9633f163a764562c84f29b0e216041b348382..2a2f250fa495d03dcfd442a821c8fc10413a2511 100644 (file)
@@ -194,8 +194,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
                to_intel_plane(crtc->base.primary);
        struct intel_plane_state *plane_state =
                to_intel_plane_state(plane->base.state);
-       struct intel_crtc_state *crtc_state =
-               to_intel_crtc_state(crtc->base.state);
        struct drm_framebuffer *fb;
        struct i915_vma *vma;
 
@@ -241,14 +239,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
        atomic_or(plane->frontbuffer_bit, &to_intel_frontbuffer(fb)->bits);
 
        plane_config->vma = vma;
-
-       /*
-        * Flip to the newly created mapping ASAP, so we can re-use the
-        * first part of GGTT for WOPCM, prevent flickering, and prevent
-        * the lookup of sysmem scratch pages.
-        */
-       plane->check_plane(crtc_state, plane_state);
-       plane->async_flip(NULL, plane, crtc_state, plane_state, true);
        return;
 
 nofb: