]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
regmap-irq: Consistently use memset32() in regmap_irq_thread()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 25 Sep 2024 08:27:26 +0000 (11:27 +0300)
committerMark Brown <broonie@kernel.org>
Sun, 29 Sep 2024 23:11:09 +0000 (01:11 +0200)
The commit 4d60cac951fd ("regmap-irq: Add no_status support") adds
an additional branch into IRQ thread handler in regmap. It wisely
chose to use memset32() as it might be optimised on some architectures
and hence give a performance benefit. At the same time the old code
continue using simple memset(). Update the old code to use memset32().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20240925082726.620622-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/regmap-irq.c

index a750e48a26b87c50f7a80df41b711f713cecac23..33ec28e3a802521ccf1d7f5ca51a868de3026a9d 100644 (file)
@@ -364,14 +364,11 @@ static irqreturn_t regmap_irq_thread(int irq, void *d)
                memset32(data->status_buf, GENMASK(31, 0), chip->num_regs);
        } else if (chip->num_main_regs) {
                unsigned int max_main_bits;
-               unsigned long size;
-
-               size = chip->num_regs * sizeof(unsigned int);
 
                max_main_bits = (chip->num_main_status_bits) ?
                                 chip->num_main_status_bits : chip->num_regs;
                /* Clear the status buf as we don't read all status regs */
-               memset(data->status_buf, 0, size);
+               memset32(data->status_buf, 0, chip->num_regs);
 
                /* We could support bulk read for main status registers
                 * but I don't expect to see devices with really many main