]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
bpf: remove redeclaration of new_n in bpf_verifier_vlog
authorRafael Passos <rafael@rcpassos.me>
Sat, 15 Jun 2024 02:24:10 +0000 (23:24 -0300)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 21 Jun 2024 02:50:26 +0000 (19:50 -0700)
This new_n is defined in the start of this function.
Its value is overwritten by `new_n = min(n, log->len_total);`
a couple lines before my change,
rendering the shadow declaration unnecessary.

Signed-off-by: Rafael Passos <rafael@rcpassos.me>
Link: https://lore.kernel.org/r/20240615022641.210320-4-rafael@rcpassos.me
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/log.c

index 3f4ae92e549ffae411dfe620ecfa8bd9cec2a450..5aebfc3051e3a63b84620283a98c6cd73949b56d 100644 (file)
@@ -91,7 +91,7 @@ void bpf_verifier_vlog(struct bpf_verifier_log *log, const char *fmt,
                        goto fail;
        } else {
                u64 new_end, new_start;
-               u32 buf_start, buf_end, new_n;
+               u32 buf_start, buf_end;
 
                new_end = log->end_pos + n;
                if (new_end - log->start_pos >= log->len_total)