mtd: nand: sh_flctl: fix error return code in flctl_probe()

platform_get_irq() returns an error code, but the sh_flctl
driver ignores it and always returns -ENXIO. This is not correct
and, prevents -EPROBE_DEFER from being propagated properly.

Print and propagate the return value of platform_get_irq on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>

diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
index 2404d6634bda8c8eb678ad69b6f80842f58466d9..d2afd57bc1f24bb8b3ab67e7366ea1fe76a84ce5 100644 (file)
--- a/drivers/mtd/nand/sh_flctl.c
+++ b/drivers/mtd/nand/sh_flctl.c
@@ -1141,8 +1141,8 @@ static int flctl_probe(struct platform_device *pdev)
 
        irq = platform_get_irq(pdev, 0);
        if (irq < 0) {
-               dev_err(&pdev->dev, "failed to get flste irq data\n");
-               return -ENXIO;
+               dev_err(&pdev->dev, "failed to get flste irq data: %d\n", irq);
+               return irq;
        }
 
        ret = devm_request_irq(&pdev->dev, irq, flctl_handle_flste, IRQF_SHARED,