]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm: rework FB_CORE dependency
authorArnd Bergmann <arnd@arndb.de>
Mon, 16 Dec 2024 07:42:49 +0000 (08:42 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 17 Dec 2024 17:28:43 +0000 (18:28 +0100)
The 'select FB_CORE' statement moved from CONFIG_DRM to DRM_CLIENT_LIB,
but there are now configurations that have code calling into fb_core
as built-in even though the client_lib itself is a loadable module:

x86_64-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_set_suspend':
drm_fb_helper.c:(.text+0x2c6): undefined reference to `fb_set_suspend'
x86_64-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_resume_worker':
drm_fb_helper.c:(.text+0x2e1): undefined reference to `fb_set_suspend'

In addition to DRM_CLIENT_LIB, the 'select' needs to be at least in
DRM_KMS_HELPER and DRM_GEM_SHMEM_HELPER, so add it here.

This patch is the KMS_HELPER part of [1].

Fixes: dadd28d4142f ("drm/client: Add client-lib module")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/series/141411/
Link: https://patchwork.freedesktop.org/patch/msgid/20241216074450.8590-4-tzimmermann@suse.de
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
drivers/gpu/drm/Kconfig

index ccee570eab7dbdcfd9a4c17cc39bfb0602afba20..772fc7625639de07de873afa0e5e0c37bf4f4420 100644 (file)
@@ -99,6 +99,7 @@ config DRM_KUNIT_TEST
 config DRM_KMS_HELPER
        tristate
        depends on DRM
+       select FB_CORE if DRM_FBDEV_EMULATION
        help
          CRTC helpers for KMS drivers.