]> www.infradead.org Git - users/willy/pagecache.git/commitdiff
buffer: Use folio_end_read()
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Wed, 19 Jul 2023 14:31:52 +0000 (10:31 -0400)
committerMatthew Wilcox (Oracle) <willy@infradead.org>
Wed, 4 Oct 2023 01:07:32 +0000 (21:07 -0400)
There are two places that we can use this new helper.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
fs/buffer.c

index 12e9a71c693d740a80ad5aa92b4653004a381711..b7bafba8727303f2346a26941971fef614a7d5dc 100644 (file)
@@ -282,13 +282,7 @@ static void end_buffer_async_read(struct buffer_head *bh, int uptodate)
        } while (tmp != bh);
        spin_unlock_irqrestore(&first->b_uptodate_lock, flags);
 
-       /*
-        * If all of the buffers are uptodate then we can set the page
-        * uptodate.
-        */
-       if (folio_uptodate)
-               folio_mark_uptodate(folio);
-       folio_unlock(folio);
+       folio_end_read(folio, folio_uptodate);
        return;
 
 still_busy:
@@ -2425,12 +2419,10 @@ int block_read_full_folio(struct folio *folio, get_block_t *get_block)
 
        if (!nr) {
                /*
-                * All buffers are uptodate - we can set the folio uptodate
-                * as well. But not if get_block() returned an error.
+                * All buffers are uptodate or get_block() returned an
+                * error when trying to map them - we can finish the read.
                 */
-               if (!page_error)
-                       folio_mark_uptodate(folio);
-               folio_unlock(folio);
+               folio_end_read(folio, !page_error);
                return 0;
        }