]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
char: misc: make miscdevice unit test built-in only
authorThadeu Lima de Souza Cascardo <cascardo@igalia.com>
Wed, 30 Apr 2025 16:36:28 +0000 (13:36 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Apr 2025 19:03:52 +0000 (21:03 +0200)
Since it uses __init symbols, it cannot be a module. Builds with
CONFIG_TEST_MISC_MINOR=m will fail with:

ERROR: modpost: "init_mknod" [drivers/misc/misc_minor_kunit.ko] undefined!
ERROR: modpost: "init_unlink" [drivers/misc/misc_minor_kunit.ko] undefined!

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/linux-next/20250429155404.2b6fe5b1@canb.auug.org.au/
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202504160338.BjUL3Owb-lkp@intel.com/
Fixes: 45f0de4f8dc3 ("char: misc: add test cases")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Link: https://lore.kernel.org/r/20250430-misc-test-fixup-v1-1-6f39ed6c733d@igalia.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
lib/Kconfig.debug

index f9051ab610d54358b21d61c141b737bb345b4cee..0117b852bd131b8a585dc02d8225e2e8c0740077 100644 (file)
@@ -2512,7 +2512,7 @@ config TEST_IDA
        tristate "Perform selftest on IDA functions"
 
 config TEST_MISC_MINOR
-       tristate "miscdevice KUnit test" if !KUNIT_ALL_TESTS
+       bool "miscdevice KUnit test" if !KUNIT_ALL_TESTS
        depends on KUNIT
        default KUNIT_ALL_TESTS
        help