]> www.infradead.org Git - linux.git/commitdiff
selftests: filesystems: fix warn_unused_result build warnings
authorAmer Al Shanawany <amer.shanawany@gmail.com>
Wed, 17 Apr 2024 18:49:13 +0000 (20:49 +0200)
committerShuah Khan <skhan@linuxfoundation.org>
Tue, 11 Jun 2024 15:21:30 +0000 (09:21 -0600)
Fix the following warnings by adding return check and error messages.

statmount_test.c: In function ‘cleanup_namespace’:
statmount_test.c:128:9: warning: ignoring return value of ‘fchdir’
declared with attribute ‘warn_unused_result’ [-Wunused-result]
  128 |         fchdir(orig_root);
      |         ^~~~~~~~~~~~~~~~~
statmount_test.c:129:9: warning: ignoring return value of ‘chroot’
declared with attribute ‘warn_unused_result’ [-Wunused-result]
  129 |         chroot(".");
      |         ^~~~~~~~~~~

Signed-off-by: Amer Al Shanawany <amer.shanawany@gmail.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/filesystems/statmount/statmount_test.c

index e6d7c4f1c85b50503c90056cae2d537b80710dd0..e8c019d72cbf3d544fc7d1b0e89f9f9288003158 100644 (file)
@@ -125,8 +125,16 @@ static uint32_t old_root_id, old_parent_id;
 
 static void cleanup_namespace(void)
 {
-       fchdir(orig_root);
-       chroot(".");
+       int ret;
+
+       ret = fchdir(orig_root);
+       if (ret == -1)
+               ksft_perror("fchdir to original root");
+
+       ret = chroot(".");
+       if (ret == -1)
+               ksft_perror("chroot to original root");
+
        umount2(root_mntpoint, MNT_DETACH);
        rmdir(root_mntpoint);
 }