]> www.infradead.org Git - users/sagi/blktests.git/commitdiff
block/002,scsi/007,zbd/003: remove options for shellcheck SC2119
authorShin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Thu, 31 Aug 2023 06:25:45 +0000 (15:25 +0900)
committerShin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Fri, 1 Sep 2023 00:07:22 +0000 (09:07 +0900)
The commits 852996fea4f1 and 45b203cce8ba added options of a few
function calls to avoid the shellcheck warning SC2119. After that,
SC2119 was disabled with the commit 3d1c0fe2677d. Then the added options
are no longer needed. Remove them to clean up.

Link: https://lore.kernel.org/linux-nvme/o5xnqvujzakhrudv7p64owiuzgozmean6blxow4vdxhdqozg5v@qznf2tzmey7k/
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
tests/block/002
tests/scsi/007
tests/zbd/003

index b16d014e7ddaeff3fb1ac0e71108d7f606e7c729..ee8b0bcdd5488a8a0eb053f7609f4da25ae61e32 100755 (executable)
@@ -19,7 +19,7 @@ requires() {
 test() {
        echo "Running ${TEST_NAME}"
 
-       if ! _configure_scsi_debug delay=0; then
+       if ! _configure_scsi_debug; then
                return 1
        fi
 
index 547a7357140c75ee53959f08c46aef2a3f78f8dd..fa8a3fcb7541a0bc2ae4e1bbaa7e096a9ab7f191 100755 (executable)
@@ -28,7 +28,7 @@ test() {
 
        echo "Running ${TEST_NAME}"
 
-       if ! _init_scsi_debug delay=0; then
+       if ! _init_scsi_debug; then
                return 1
        fi
 
index 44dba175f7d04c945d6b6cf6e40a1e9f02d8434f..7f4fa2cf567207b0c26639478250b8643ea2811c 100755 (executable)
@@ -43,7 +43,7 @@ test_device() {
 
        # Select 2 target zones so that reset zone range also get tested
        _get_blkzone_report "${TEST_DEV}" || return $?
-       zone_idx=$(_find_two_contiguous_seq_zones "") || return $?
+       zone_idx=$(_find_two_contiguous_seq_zones) || return $?
        target_zones=( "${zone_idx}" "$((zone_idx + 1))" )
 
        # Reset the 2 target zones and write 4KB in each zone to increment