]> www.infradead.org Git - users/willy/xarray.git/commitdiff
coresight: cpu-debug: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Jun 2019 15:52:46 +0000 (17:52 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Jun 2019 13:46:30 +0000 (15:46 +0200)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: linux-arm-kernel@lists.infradead.org
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwtracing/coresight/coresight-cpu-debug.c

index e8819d7509387a065842f577c20781757e0a94c3..6446ed69ab2f629c5f1c56e6a54272837bc747bf 100644 (file)
@@ -525,23 +525,12 @@ static const struct file_operations debug_func_knob_fops = {
 
 static int debug_func_init(void)
 {
-       struct dentry *file;
        int ret;
 
        /* Create debugfs node */
        debug_debugfs_dir = debugfs_create_dir("coresight_cpu_debug", NULL);
-       if (!debug_debugfs_dir) {
-               pr_err("%s: unable to create debugfs directory\n", __func__);
-               return -ENOMEM;
-       }
-
-       file = debugfs_create_file("enable", 0644, debug_debugfs_dir, NULL,
-                                  &debug_func_knob_fops);
-       if (!file) {
-               pr_err("%s: unable to create enable knob file\n", __func__);
-               ret = -ENOMEM;
-               goto err;
-       }
+       debugfs_create_file("enable", 0644, debug_debugfs_dir, NULL,
+                           &debug_func_knob_fops);
 
        /* Register function to be called for panic */
        ret = atomic_notifier_chain_register(&panic_notifier_list,