]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
irqchip/ti-sci-intr: Fix unsigned comparison to zero
authorYueHaibing <yuehaibing@huawei.com>
Wed, 26 Aug 2020 03:53:21 +0000 (11:53 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 09:11:01 +0000 (10:11 +0100)
[ Upstream commit 8ddf1905a904ca86d71ca1c435e4b0b2a0b70df8 ]

ti_sci_intr_xlate_irq() return -ENOENT on fail, p_hwirq
should be int type.

Fixes: a5b659bd4bc7 ("irqchip/ti-sci-intr: Add support for INTR being a parent to INTR")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Acked-by: Lokesh Vutla <lokeshvutla@ti.com>
Link: https://lore.kernel.org/r/20200826035321.18620-1-yuehaibing@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/irqchip/irq-ti-sci-intr.c

index cbc1758228d9e91a98dd2ef8aaa13ff060d85907..85a72b56177cf26d9c48301848e749110a335285 100644 (file)
@@ -137,8 +137,8 @@ static int ti_sci_intr_alloc_parent_irq(struct irq_domain *domain,
        struct ti_sci_intr_irq_domain *intr = domain->host_data;
        struct device_node *parent_node;
        struct irq_fwspec fwspec;
-       u16 out_irq, p_hwirq;
-       int err = 0;
+       int p_hwirq, err = 0;
+       u16 out_irq;
 
        out_irq = ti_sci_get_free_resource(intr->out_irqs);
        if (out_irq == TI_SCI_RESOURCE_NULL)