tmp is an "unsigned long" variable so it can't be less than zero.
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
}
tmp = atoi(argv[1]);
- if (tmp < 0 || tmp > 0xffff) {
+ if (tmp > 0xffff) {
fprintf(stderr, "invalid controller ID\n");
return -1;
}
ctrl_id = tmp & 0xffff;
tmp = atoi(argv[2]);
- if (tmp < 0 || tmp > 0xff) {
+ if (tmp > 0xff) {
fprintf(stderr, "invalid opcode\n");
return -1;
}
}
tmp = atoi(argv[1]);
- if (tmp < 0 || tmp > 0xffff) {
+ if (tmp > 0xffff) {
fprintf(stderr, "invalid controller ID\n");
return -1;
}