]> www.infradead.org Git - users/sagi/libnvme.git/commitdiff
mi: fix a static checker warning in examples/mi-mctp
authorMaurizio Lombardi <mlombard@redhat.com>
Tue, 8 Nov 2022 09:54:32 +0000 (10:54 +0100)
committerDaniel Wagner <dwagner@suse.de>
Wed, 9 Nov 2022 09:30:09 +0000 (10:30 +0100)
tmp is an "unsigned long" variable so it can't be less than zero.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
examples/mi-mctp.c

index 8d660afb27506582453a10ad77e6e6d462dd9e57..c9a38523f4b521f0426b56a1b460c499d202de20 100644 (file)
@@ -347,14 +347,14 @@ int do_admin_raw(nvme_mi_ep_t ep, int argc, char **argv)
        }
 
        tmp = atoi(argv[1]);
-       if (tmp < 0 || tmp > 0xffff) {
+       if (tmp > 0xffff) {
                fprintf(stderr, "invalid controller ID\n");
                return -1;
        }
        ctrl_id = tmp & 0xffff;
 
        tmp = atoi(argv[2]);
-       if (tmp < 0 || tmp > 0xff) {
+       if (tmp > 0xff) {
                fprintf(stderr, "invalid opcode\n");
                return -1;
        }
@@ -461,7 +461,7 @@ int do_security_info(nvme_mi_ep_t ep, int argc, char **argv)
        }
 
        tmp = atoi(argv[1]);
-       if (tmp < 0 || tmp > 0xffff) {
+       if (tmp > 0xffff) {
                fprintf(stderr, "invalid controller ID\n");
                return -1;
        }