]> www.infradead.org Git - users/hch/block.git/commitdiff
PM/hibernate: remove the bogus call to get_gendisk in software_resume
authorChristoph Hellwig <hch@lst.de>
Mon, 31 Aug 2020 13:21:52 +0000 (15:21 +0200)
committerChristoph Hellwig <hch@lst.de>
Wed, 23 Sep 2020 18:24:53 +0000 (20:24 +0200)
get_gendisk grabs a reference on the disk and file operation, so this
code will leak both of them while having absolutely no use for the
gendisk itself.

This effectively reverts commit 2df83fa4bce421f
("PM / Hibernate: Use get_gendisk to verify partition if resume_file is integer format")

Signed-off-by: Christoph Hellwig <hch@lst.de>
kernel/power/hibernate.c

index e7aa57fb2fdc33a587befb1c5a2d668224961bdc..7d0b99d2e696313c3dd0b969eef4be9dcf0c653c 100644 (file)
@@ -948,17 +948,6 @@ static int software_resume(void)
 
        /* Check if the device is there */
        swsusp_resume_device = name_to_dev_t(resume_file);
-
-       /*
-        * name_to_dev_t is ineffective to verify parition if resume_file is in
-        * integer format. (e.g. major:minor)
-        */
-       if (isdigit(resume_file[0]) && resume_wait) {
-               int partno;
-               while (!get_gendisk(swsusp_resume_device, &partno))
-                       msleep(10);
-       }
-
        if (!swsusp_resume_device) {
                /*
                 * Some device discovery might still be in progress; we need