drm/bridge: adv7511: Move adv711_dsi_config_timing_gen() into adv7511_mode_set()

adv7511_mode_set() currently updates only the sync registers of the ADV
bridge. At the end, drm_mode_copy() updates the current mode, but the
horizontal and vertical porch registers of the ADV bridge still retain
values from the old mode.

Move adv7511_dsi_config_timing_gen() into adv7511_mode_set() to ensure
the horizontal and vertical porch registers are correctly updated.

Fixes: ae01d3183d2763ed ("drm/bridge: adv7511: switch to the HDMI connector helpers")
Reported-by: Biju Das <biju.das.jz@bp.renesas.com>
Closes: https://lore.kernel.org/all/aDB8bD6cF7qiSpKd@tom-desktop/
Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Tested-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250528070452.901183-2-tommaso.merciai.xr@bp.renesas.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h
index 0ecce9e4947adcc14d72e7bddbadf8defed34d52..19046e61e015389b4d65cf6083f2785b209c87de 100644 (file)
--- a/drivers/gpu/drm/bridge/adv7511/adv7511.h
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h
@@ -422,6 +422,8 @@ int adv7533_patch_cec_registers(struct adv7511 *adv);
 int adv7533_attach_dsi(struct adv7511 *adv);
 int adv7533_parse_dt(struct device_node *np, struct adv7511 *adv);
 
+void adv7511_dsi_config_timing_gen(struct adv7511 *adv);
+
 #ifdef CONFIG_DRM_I2C_ADV7511_AUDIO
 int adv7511_hdmi_audio_startup(struct drm_connector *connector,
                               struct drm_bridge *bridge);

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index 022b6d9c2a1f71b2192d5d44e66a60859706ab69..218fff19dd0d58342aa67f7c6c27eb2f634f848f 100644 (file)
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -738,6 +738,10 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
 
        drm_mode_copy(&adv7511->curr_mode, adj_mode);
 
+       /* Update horizontal/vertical porch params */
+       if (adv7511->info->has_dsi && adv7511->use_timing_gen)
+               adv7511_dsi_config_timing_gen(adv7511);
+
        /*
         * TODO Test first order 4:2:2 to 4:4:4 up conversion method, which is
         * supposed to give better results.

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7533.c b/drivers/gpu/drm/bridge/adv7511/adv7533.c
index b12d422343fc139e8d9b59a2ded60ce08ce43dc8..df8180e6d733364ddfe5f474c4735d0588767906 100644 (file)
--- a/drivers/gpu/drm/bridge/adv7511/adv7533.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7533.c
@@ -24,7 +24,7 @@ static const struct reg_sequence adv7533_cec_fixed_registers[] = {
        { 0x05, 0xc8 },
 };
 
-static void adv7511_dsi_config_timing_gen(struct adv7511 *adv)
+void adv7511_dsi_config_timing_gen(struct adv7511 *adv)
 {
        struct mipi_dsi_device *dsi = adv->dsi;
        struct drm_display_mode *mode = &adv->curr_mode;
@@ -67,9 +67,6 @@ void adv7533_dsi_power_on(struct adv7511 *adv)
 {
        struct mipi_dsi_device *dsi = adv->dsi;
 
-       if (adv->use_timing_gen)
-               adv7511_dsi_config_timing_gen(adv);
-
        /* set number of dsi lanes */
        regmap_write(adv->regmap_cec, 0x1c, dsi->lanes << 4);