]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
coresight: cti: Reduce scope for the variable “cs_fwnode” in cti_plat_create_connection()
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 9 Dec 2020 20:34:48 +0000 (21:34 +0100)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Thu, 10 Dec 2020 21:39:28 +0000 (14:39 -0700)
A local variable was used only within an else branch.
Thus move the definition for the variable “cs_fwnode” into
the corresponding code block.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/hwtracing/coresight/coresight-cti-platform.c

index 98f830c6ed5070ef0fb74a767efe6322d1dd3789..ccef04f27f12faecd0c8e236f5ba479735a01ae8 100644 (file)
@@ -343,7 +343,6 @@ static int cti_plat_create_connection(struct device *dev,
 {
        struct cti_trig_con *tc = NULL;
        int cpuid = -1, err = 0;
-       struct fwnode_handle *cs_fwnode = NULL;
        struct coresight_device *csdev = NULL;
        const char *assoc_name = "unknown";
        char cpu_name_str[16];
@@ -397,8 +396,9 @@ static int cti_plat_create_connection(struct device *dev,
                assoc_name = cpu_name_str;
        } else {
                /* associated device ? */
-               cs_fwnode = fwnode_find_reference(fwnode,
-                                                 CTI_DT_CSDEV_ASSOC, 0);
+               struct fwnode_handle *cs_fwnode = fwnode_find_reference(fwnode,
+                                                                       CTI_DT_CSDEV_ASSOC,
+                                                                       0);
                if (!IS_ERR(cs_fwnode)) {
                        assoc_name = cti_plat_get_csdev_or_node_name(cs_fwnode,
                                                                     &csdev);