scsi: qla2xxx: Suppress endianness complaints in qla2x00_configure_local_loop()

Instead of changing endianness in-place, write the data in CPU endian
format in another buffer and copy that buffer back. This patch does not
change any functionality but silences some sparse endianness warnings.

Link: https://lore.kernel.org/r/20200220043441.20504-3-bvanassche@acm.org
Cc: Roman Bolshakov <r.bolshakov@yadro.com>
Cc: Martin Wilck <mwilck@suse.com>
Cc: Quinn Tran <qutran@marvell.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
index 138152c2673325337a4337b84ed05b12fdc107b5..163e140490c7dc7482a806b981a30ff7da3a519c 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_def.h
+++ b/drivers/scsi/qla2xxx/qla_def.h
@@ -414,7 +414,7 @@ struct els_logo_payload {
 struct els_plogi_payload {
        uint8_t opcode;
        uint8_t rsvd[3];
-       uint8_t data[112];
+       __be32  data[112 / 4];
 };
 
 struct ct_arg {

diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 1ec93e28560e621cc630df5315670258dc51d337..12fcf5b5932a2da65d1974883367be0ff5aa2444 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -5076,7 +5076,7 @@ qla2x00_configure_local_loop(scsi_qla_host_t *vha)
        if (N2N_TOPO(ha)) {
                if (test_and_clear_bit(N2N_LOGIN_NEEDED, &vha->dpc_flags)) {
                        /* borrowing */
-                       u32 *bp, i, sz;
+                       u32 *bp, sz;
 
                        memset(ha->init_cb, 0, ha->init_cb_size);
                        sz = min_t(int, sizeof(struct els_plogi_payload),
@@ -5084,13 +5084,12 @@ qla2x00_configure_local_loop(scsi_qla_host_t *vha)
                        rval = qla24xx_get_port_login_templ(vha,
                            ha->init_cb_dma, (void *)ha->init_cb, sz);
                        if (rval == QLA_SUCCESS) {
+                               __be32 *q = &ha->plogi_els_payld.data[0];
+
                                bp = (uint32_t *)ha->init_cb;
-                               for (i = 0; i < sz/4 ; i++, bp++)
-                                       *bp = cpu_to_be32(*bp);
+                               cpu_to_be32_array(q, bp, sz / 4);
 
-                               memcpy(&ha->plogi_els_payld.data,
-                                   (void *)ha->init_cb,
-                                   sizeof(ha->plogi_els_payld.data));
+                               memcpy(bp, q, sizeof(ha->plogi_els_payld.data));
                        } else {
                                ql_dbg(ql_dbg_init, vha, 0x00d1,
                                    "PLOGI ELS param read fail.\n");