]> www.infradead.org Git - users/hch/blktests.git/commitdiff
new: fix test case addition to new test group
authorShin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Tue, 19 Jul 2022 03:10:36 +0000 (12:10 +0900)
committerShin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Sun, 24 Jul 2022 23:47:27 +0000 (08:47 +0900)
The "new" script adds script files for a new test case to the specified
test group. However, this file addition fails when the user specifies
non-existing new test group name as the target test group. The failure
happens because the "new" script assumes the target test group directory
has at least one test case, but this is not true when a new group is
created. Fix this by checking the existence of the test cases in the
target test group.

Fixes: b1e29e775872 ("Create test name from most recently used test number")
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
new

diff --git a/new b/new
index 8f63831a8bb0aa7f7ce4b95cddd217590fa42bea..e8ee5a05c2065d77a4f8a9e70e0f3bbb7842f9a4 100755 (executable)
--- a/new
+++ b/new
@@ -98,10 +98,13 @@ EOF
        echo "Created tests/${group}/rc"
 fi
 
+seq=0
 for test in tests/"$group"/+([0-9]); do
-       :
+       if [[ -e $test ]]; then
+               seq=${test##tests/"${group}"/+(0)}
+       fi
 done
-seq=${test##tests/"${group}"/+(0)}
+
 test_name="${group}/$(printf "%03d" $((seq + 1)))"
 
 cat << EOF > "tests/${test_name}"