]> www.infradead.org Git - users/willy/xarray.git/commitdiff
NTB: amd: Silence shift wrapping warning in amd_ntb_db_vector_mask()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 25 Mar 2019 09:23:26 +0000 (12:23 +0300)
committerJon Mason <jdmason@kudzu.us>
Thu, 13 Jun 2019 12:59:18 +0000 (08:59 -0400)
This code triggers a Smatch warning:

    drivers/ntb/hw/amd/ntb_hw_amd.c:336 amd_ntb_db_vector_mask()
    warn: should '(1 << db_vector)' be a 64 bit type?

I don't think "db_vector" can be higher than 16 so this doesn't affect
runtime, but it's nice to silence the static checker warning and we
might increase "ndev->db_count" in the future.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
drivers/ntb/hw/amd/ntb_hw_amd.c

index cd463e13203520ce4670437e612390ef569a770f..2859cc99b73e65beaecc45e620cbda7898fd0daa 100644 (file)
@@ -333,7 +333,7 @@ static u64 amd_ntb_db_vector_mask(struct ntb_dev *ntb, int db_vector)
        if (db_vector < 0 || db_vector > ndev->db_count)
                return 0;
 
-       return ntb_ndev(ntb)->db_valid_mask & (1 << db_vector);
+       return ntb_ndev(ntb)->db_valid_mask & (1ULL << db_vector);
 }
 
 static u64 amd_ntb_db_read(struct ntb_dev *ntb)