]> www.infradead.org Git - users/hch/misc.git/commitdiff
clk: qcom: common: Fix NULL vs IS_ERR() check in qcom_cc_icc_register()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 2 Sep 2025 06:33:36 +0000 (09:33 +0300)
committerBjorn Andersson <andersson@kernel.org>
Thu, 4 Sep 2025 13:36:57 +0000 (08:36 -0500)
The devm_clk_hw_get_clk() function doesn't return NULL, it returns error
pointers.  Update the checking to match.

Fixes: 8737ec830ee3 ("clk: qcom: common: Add interconnect clocks support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/aLaPwL2gFS85WsfD@stanley.mountain
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/clk/qcom/common.c

index 37c3008e6c1be1f083d0093d2659e31dd7978497..121591886774181cd320baee442506f406dc2c67 100644 (file)
@@ -277,8 +277,8 @@ static int qcom_cc_icc_register(struct device *dev,
                icd[i].slave_id = desc->icc_hws[i].slave_id;
                hws = &desc->clks[desc->icc_hws[i].clk_id]->hw;
                icd[i].clk = devm_clk_hw_get_clk(dev, hws, "icc");
-               if (!icd[i].clk)
-                       return dev_err_probe(dev, -ENOENT,
+               if (IS_ERR(icd[i].clk))
+                       return dev_err_probe(dev, PTR_ERR(icd[i].clk),
                                             "(%d) clock entry is null\n", i);
                icd[i].name = clk_hw_get_name(hws);
        }