slimbus: qcom-ngd-ctrl: disable ngd in qmi server down callback

[ Upstream commit 709ec3f7fc5773ac4aa6fb22c3f0ac8103c674db ]

In QMI new server notification we enable the NGD however during
delete server notification we do not disable the NGD.

This can lead to multiple instances of NGD being enabled, so make
sure that we disable NGD in delete server callback to fix this issue!

Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20200925095520.27316-4-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
index f40ac8dcb081749fa5fb5ae169b5bd214a0dfea3..522a87fc573a6c9aabd0371e242669c754513815 100644 (file)
--- a/drivers/slimbus/qcom-ngd-ctrl.c
+++ b/drivers/slimbus/qcom-ngd-ctrl.c
@@ -1272,9 +1272,13 @@ static void qcom_slim_ngd_qmi_del_server(struct qmi_handle *hdl,
 {
        struct qcom_slim_ngd_qmi *qmi =
                container_of(hdl, struct qcom_slim_ngd_qmi, svc_event_hdl);
+       struct qcom_slim_ngd_ctrl *ctrl =
+               container_of(qmi, struct qcom_slim_ngd_ctrl, qmi);
 
        qmi->svc_info.sq_node = 0;
        qmi->svc_info.sq_port = 0;
+
+       qcom_slim_ngd_enable(ctrl, false);
 }
 
 static struct qmi_ops qcom_slim_ngd_qmi_svc_event_ops = {