]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
RDMA/hns: Fix error return code in hns_roce_v1_rsv_lp_qp()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 1 Aug 2019 01:27:25 +0000 (01:27 +0000)
committerSasha Levin <sashal@kernel.org>
Sun, 25 Aug 2019 14:10:33 +0000 (10:10 -0400)
[ Upstream commit 020fb3bebc224dfe9353a56ecbe2d5fac499dffc ]

Fix to return error code -ENOMEM from the rdma_zalloc_drv_obj() error
handling case instead of 0, as done elsewhere in this function.

Fixes: e8ac9389f0d7 ("RDMA: Fix allocation failure on pointer pd")
Fixes: 21a428a019c9 ("RDMA: Handle PD allocations by IB/core")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Link: https://lore.kernel.org/r/20190801012725.150493-1-weiyongjun1@huawei.com
Signed-off-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/hw/hns/hns_roce_hw_v1.c

index e068a02122f5e3e5054d4b9b402500f8028c5e6e..9496c69fff3a274badaf9333d3fd5d4daf004d89 100644 (file)
@@ -745,8 +745,10 @@ static int hns_roce_v1_rsv_lp_qp(struct hns_roce_dev *hr_dev)
 
        ibdev = &hr_dev->ib_dev;
        pd = rdma_zalloc_drv_obj(ibdev, ib_pd);
-       if (!pd)
+       if (!pd) {
+               ret = -ENOMEM;
                goto alloc_mem_failed;
+       }
 
        pd->device  = ibdev;
        ret = hns_roce_alloc_pd(pd, NULL);