]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
mm/damon/core: do not call damos_walk_control->walk() if walk is completed
authorSeongJae Park <sj@kernel.org>
Mon, 10 Feb 2025 18:27:35 +0000 (10:27 -0800)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 28 Feb 2025 00:59:55 +0000 (16:59 -0800)
damos_walk() invokes callback functions of schemes until all schemes
finishes at least one round of walks.  If there are multiple DAMOS schemes
having different apply_interval, the callback functions for longer apply
interval scheme will be called for more than a round of the walk.

The behavior is different from the document (see damos_walk() kernel-doc
comment), and not useful.  Make the behavior be same to the documented
one, by stopping invoking the callback if the walk for the given scheme is
completed.

Link: https://lkml.kernel.org/r/20250210182737.134994-3-sj@kernel.org
Fixes: bf0eaba0ff9c ("mm/damon/core: implement damos_walk()")
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/core.c

index 1d9025d14d832f6b083be893095a988594c28966..4b865b2558d990c772491ebd6ad121b3f3d01736 100644 (file)
@@ -1453,6 +1453,9 @@ static void damos_walk_call_walk(struct damon_ctx *ctx, struct damon_target *t,
 {
        struct damos_walk_control *control;
 
+       if (s->walk_completed)
+               return;
+
        mutex_lock(&ctx->walk_control_lock);
        control = ctx->walk_control;
        mutex_unlock(&ctx->walk_control_lock);