projects
/
users
/
willy
/
xarray.git
/ commitdiff
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5d5fc33
)
riscv: signal: Remove unlikely() from WARN_ON() condition
author
Zhongqiu Han <quic_zhonhan@quicinc.com>
Thu, 20 Jun 2024 03:34:34 +0000
(11:34 +0800)
committer
Palmer Dabbelt <palmer@rivosinc.com>
Fri, 26 Jul 2024 12:50:46 +0000
(
05:50
-0700)
"WARN_ON(unlikely(x))" is excessive. WARN_ON() already uses unlikely()
internally.
Signed-off-by: Zhongqiu Han <quic_zhonhan@quicinc.com>
Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Reviewed-by: Andy Chiu <andy.chiu@sifive.com>
Link:
https://lore.kernel.org/r/20240620033434.3778156-1-quic_zhonhan@quicinc.com
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
arch/riscv/kernel/signal.c
patch
|
blob
|
history
diff --git
a/arch/riscv/kernel/signal.c
b/arch/riscv/kernel/signal.c
index 5a2edd7f027e5d12e682349c3f1b54b51cd3b735..dcd282419456137b81206cfdcf2676999550ab9f 100644
(file)
--- a/
arch/riscv/kernel/signal.c
+++ b/
arch/riscv/kernel/signal.c
@@
-84,7
+84,7
@@
static long save_v_state(struct pt_regs *regs, void __user **sc_vec)
datap = state + 1;
/* datap is designed to be 16 byte aligned for better performance */
- WARN_ON(
unlikely(!IS_ALIGNED((unsigned long)datap, 16)
));
+ WARN_ON(
!IS_ALIGNED((unsigned long)datap, 16
));
get_cpu_vector_context();
riscv_v_vstate_save(¤t->thread.vstate, regs);