]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
hwmon: (nct7802): Simplify with scoped for each OF child loop
authorJinjie Ruan <ruanjinjie@huawei.com>
Thu, 22 Aug 2024 06:29:53 +0000 (14:29 +0800)
committerGuenter Roeck <linux@roeck-us.net>
Tue, 27 Aug 2024 15:11:15 +0000 (08:11 -0700)
Use scoped for_each_child_of_node_scoped() when iterating over device
nodes to make code a bit simpler.

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Message-ID: <20240822062956.3490387-6-ruanjinjie@huawei.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/nct7802.c

index 5e83504800a3049bc02b9b8264149633e0afb802..8c9351da12c6e79c14eccae64ba64e792c76d5a9 100644 (file)
@@ -1129,17 +1129,14 @@ static int nct7802_configure_channels(struct device *dev,
 {
        /* Enable local temperature sensor by default */
        u8 mode_mask = MODE_LTD_EN, mode_val = MODE_LTD_EN;
-       struct device_node *node;
        int err;
 
        if (dev->of_node) {
-               for_each_child_of_node(dev->of_node, node) {
+               for_each_child_of_node_scoped(dev->of_node, node) {
                        err = nct7802_get_channel_config(dev, node, &mode_mask,
                                                         &mode_val);
-                       if (err) {
-                               of_node_put(node);
+                       if (err)
                                return err;
-                       }
                }
        }