]> www.infradead.org Git - users/hch/block.git/commitdiff
net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop()
authorDiogo Ivo <diogo.ivo@siemens.com>
Thu, 15 Feb 2024 15:22:01 +0000 (15:22 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 16 Feb 2024 11:53:49 +0000 (11:53 +0000)
Remove the duplicate calls to prueth_emac_stop() and
prueth_cleanup_tx_chns() in emac_ndo_stop().

Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/icssg/icssg_prueth.c

index 411898a4f38caa73b5e88e31b554601ee079ae6d..cf7b73f8f450728930587dc0646a0bbaa1d2b476 100644 (file)
@@ -1489,9 +1489,6 @@ static int emac_ndo_stop(struct net_device *ndev)
        /* Destroying the queued work in ndo_stop() */
        cancel_delayed_work_sync(&emac->stats_work);
 
-       /* stop PRUs */
-       prueth_emac_stop(emac);
-
        if (prueth->emacs_initialized == 1)
                icss_iep_exit(emac->iep);
 
@@ -1502,7 +1499,6 @@ static int emac_ndo_stop(struct net_device *ndev)
 
        free_irq(emac->rx_chns.irq[rx_flow], emac);
        prueth_ndev_del_tx_napi(emac, emac->tx_ch_num);
-       prueth_cleanup_tx_chns(emac);
 
        prueth_cleanup_rx_chns(emac, &emac->rx_chns, max_rx_flows);
        prueth_cleanup_tx_chns(emac);