]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/sitronix/st7571-i2c: Make st7571_panel_data variables static const
authorJavier Martinez Canillas <javierm@redhat.com>
Fri, 18 Jul 2025 15:25:25 +0000 (17:25 +0200)
committerJavier Martinez Canillas <javierm@redhat.com>
Mon, 1 Sep 2025 09:27:31 +0000 (11:27 +0200)
The kernel test robot reported that sparse gives the following warnings:

make C=2 M=drivers/gpu/drm/sitronix/
  CC [M]  st7571-i2c.o
  CHECK   st7571-i2c.c
st7571-i2c.c:1027:26: warning: symbol 'st7567_config' was not declared. Should it be static?
st7571-i2c.c:1039:26: warning: symbol 'st7571_config' was not declared. Should it be static?
  MODPOST Module.symvers
  LD [M]  st7571-i2c.ko

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507180503.nfyD9uRv-lkp@intel.com
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250718152534.729770-1-javierm@redhat.com
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
drivers/gpu/drm/sitronix/st7571-i2c.c

index 453eb7e045e5fb5942720d6020b6279a4b7315d7..dda99cbe5372b0f8feb4f14826bd1ecdaa20782a 100644 (file)
@@ -1024,7 +1024,7 @@ static void st7571_remove(struct i2c_client *client)
        drm_dev_unplug(&st7571->dev);
 }
 
-struct st7571_panel_data st7567_config = {
+static const struct st7571_panel_data st7567_config = {
        .init = st7567_lcd_init,
        .parse_dt = st7567_parse_dt,
        .constraints = {
@@ -1036,7 +1036,7 @@ struct st7571_panel_data st7567_config = {
        },
 };
 
-struct st7571_panel_data st7571_config = {
+static const struct st7571_panel_data st7571_config = {
        .init = st7571_lcd_init,
        .parse_dt = st7571_parse_dt,
        .constraints = {