]> www.infradead.org Git - users/willy/xarray.git/commitdiff
of: unittest: Use of_property_present()
authorRob Herring (Arm) <robh@kernel.org>
Wed, 31 Jul 2024 19:12:48 +0000 (13:12 -0600)
committerRob Herring (Arm) <robh@kernel.org>
Tue, 6 Aug 2024 19:22:13 +0000 (13:22 -0600)
Use of_property_present() to test for property presence rather than
of_find_property(). This is part of a larger effort to remove callers
of of_find_property() and similar functions. of_find_property() leaks
the DT struct property and data pointers which is a problem for
dynamically allocated nodes which may be freed.

Link: https://lore.kernel.org/r/20240731191312.1710417-10-robh@kernel.org
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
drivers/of/unittest.c

index c830f346df45266bb2a9cb6c8a24e3ca292aa568..b60b4b7d7172c70d70103adefbe986ba3326112b 100644 (file)
@@ -900,8 +900,8 @@ static void __init of_unittest_changeset(void)
        unittest(!of_find_node_by_path("/testcase-data/changeset/n2/n21"),
                 "'%pOF' still present after revert\n", n21);
 
-       ppremove = of_find_property(parent, "prop-remove", NULL);
-       unittest(ppremove, "failed to find removed prop after revert\n");
+       unittest(of_property_present(parent, "prop-remove"),
+                "failed to find removed prop after revert\n");
 
        ret = of_property_read_string(parent, "prop-update", &propstr);
        unittest(!ret, "failed to find updated prop after revert\n");