thermal: core: Adding missing nlmsg_free() in thermal_genl_sampling_temp()

[ Upstream commit 48b458591749d35c927351b4960b49e35af30fe6 ]

thermal_genl_sampling_temp() misses to call nlmsg_free() in an error path.

Jump to out_free to fix it.

Fixes: 1ce50e7d408ef2 ("thermal: core: genetlink support for events/cmd/sampling")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20200929082652.59876-1-jingxiangfeng@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/thermal/thermal_netlink.c b/drivers/thermal/thermal_netlink.c
index af7b2383e8f6b1fc2e3863ec419bdb77ff307e10..019f4812def6ce2db43cf9e481eb17a327273699 100644 (file)
--- a/drivers/thermal/thermal_netlink.c
+++ b/drivers/thermal/thermal_netlink.c
@@ -78,7 +78,7 @@ int thermal_genl_sampling_temp(int id, int temp)
        hdr = genlmsg_put(skb, 0, 0, &thermal_gnl_family, 0,
                          THERMAL_GENL_SAMPLING_TEMP);
        if (!hdr)
-               return -EMSGSIZE;
+               goto out_free;
 
        if (nla_put_u32(skb, THERMAL_GENL_ATTR_TZ_ID, id))
                goto out_cancel;
@@ -93,6 +93,7 @@ int thermal_genl_sampling_temp(int id, int temp)
        return 0;
 out_cancel:
        genlmsg_cancel(skb, hdr);
+out_free:
        nlmsg_free(skb);
 
        return -EMSGSIZE;