mlxsw: spectrum_router: Fix error handling issue

Return error to the caller instead of suppressing it.

Fixes: e3ddfb45bacd ("mlxsw: spectrum_router: Allow returning errors from mlxsw_sp_nexthop_group_refresh()")
Addresses-Coverity: ("Error handling issues  (CHECKED_RETURN)")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
index d551e9bc373c6776bc3bbf6271908040be8e8773..118d48d9ff8eb5669ebfc9ee9db287f0fa7c4344 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
@@ -3608,10 +3608,8 @@ mlxsw_sp_nexthop_group_refresh(struct mlxsw_sp *mlxsw_sp,
        int i, err2, err = 0;
        u32 old_adj_index;
 
-       if (!nhgi->gateway) {
-               mlxsw_sp_nexthop_fib_entries_update(mlxsw_sp, nh_grp);
-               return 0;
-       }
+       if (!nhgi->gateway)
+               return mlxsw_sp_nexthop_fib_entries_update(mlxsw_sp, nh_grp);
 
        for (i = 0; i < nhgi->count; i++) {
                nh = &nhgi->nexthops[i];