]> www.infradead.org Git - users/hch/block.git/commitdiff
target: remove an incorrect unmap zeroes data deduction
authorChristoph Hellwig <hch@lst.de>
Tue, 15 Feb 2022 10:30:48 +0000 (11:30 +0100)
committerChristoph Hellwig <hch@lst.de>
Sun, 10 Apr 2022 06:26:01 +0000 (08:26 +0200)
For block devices, the SCSI target drivers implements UNMAP as calls to
blkdev_issue_discard, which does not guarantee zeroing just because
Write Zeroes is supported.

Note that this does not affect the file backed path which uses
fallocate to punch holes.

Fixes: 2237498f0b5c ("target/iblock: Convert WRITE_SAME to blkdev_issue_zeroout")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_device.c

index 44bb380e7390c7319cd8eaa3ab00c7aa57158685..fa866acef5bb2a6c56d6a772f704d3e849f22498 100644 (file)
@@ -850,7 +850,6 @@ bool target_configure_unmap_from_queue(struct se_dev_attrib *attrib,
        attrib->unmap_granularity = q->limits.discard_granularity / block_size;
        attrib->unmap_granularity_alignment = q->limits.discard_alignment /
                                                                block_size;
-       attrib->unmap_zeroes_data = !!(q->limits.max_write_zeroes_sectors);
        return true;
 }
 EXPORT_SYMBOL(target_configure_unmap_from_queue);