mlx4: replace mlx4_u64_to_mac() with u64_to_ether_addr()

mlx4_u64_to_mac() predates the common helper but doesn't
make the argument constant.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellanox/mlx4/cmd.c
index 9fadedfca41c42613fd55b8e6c881bf38382e157..94ead263081f420508709bb3cb0531d84bccd178 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlx4/cmd.c
+++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c
@@ -3195,7 +3195,7 @@ int mlx4_set_vf_spoofchk(struct mlx4_dev *dev, int port, int vf, bool setting)
        port = mlx4_slaves_closest_port(dev, slave, port);
        s_info = &priv->mfunc.master.vf_admin[slave].vport[port];
 
-       mlx4_u64_to_mac(mac, s_info->mac);
+       u64_to_ether_addr(s_info->mac, mac);
        if (setting && !is_valid_ether_addr(mac)) {
                mlx4_info(dev, "Illegal MAC with spoofchk\n");
                return -EPERM;

diff --git a/include/linux/mlx4/driver.h b/include/linux/mlx4/driver.h
index b26b71f62fb41473133347f1010af8d118dc36cf..1834c8fad12ea13c5bd764f691f9dd6e0fefc785 100644 (file)
--- a/include/linux/mlx4/driver.h
+++ b/include/linux/mlx4/driver.h
@@ -92,14 +92,4 @@ void *mlx4_get_protocol_dev(struct mlx4_dev *dev, enum mlx4_protocol proto, int
 
 struct devlink_port *mlx4_get_devlink_port(struct mlx4_dev *dev, int port);
 
-static inline void mlx4_u64_to_mac(u8 *addr, u64 mac)
-{
-       int i;
-
-       for (i = ETH_ALEN; i > 0; i--) {
-               addr[i - 1] = mac & 0xFF;
-               mac >>= 8;
-       }
-}
-
 #endif /* MLX4_DRIVER_H */