qed: Move devlink registration to be last devlink command

This change prevents from users to access device before devlink is
fully configured.

Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/qlogic/qed/qed_devlink.c b/drivers/net/ethernet/qlogic/qed/qed_devlink.c
index c51f9590fe19385e61598f4d1d7b5b9405cd5209..6bb4e165b5920623439e753832b06990aa1730ee 100644 (file)
--- a/drivers/net/ethernet/qlogic/qed/qed_devlink.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_devlink.c
@@ -215,7 +215,6 @@ struct devlink *qed_devlink_register(struct qed_dev *cdev)
        qdevlink = devlink_priv(dl);
        qdevlink->cdev = cdev;
 
-       devlink_register(dl);
        rc = devlink_params_register(dl, qed_devlink_params,
                                     ARRAY_SIZE(qed_devlink_params));
        if (rc)
@@ -226,15 +225,13 @@ struct devlink *qed_devlink_register(struct qed_dev *cdev)
                                           QED_DEVLINK_PARAM_ID_IWARP_CMT,
                                           value);
 
-       devlink_params_publish(dl);
        cdev->iwarp_cmt = false;
 
        qed_fw_reporters_create(dl);
-
+       devlink_register(dl);
        return dl;
 
 err_unregister:
-       devlink_unregister(dl);
        devlink_free(dl);
 
        return ERR_PTR(rc);
@@ -245,11 +242,11 @@ void qed_devlink_unregister(struct devlink *devlink)
        if (!devlink)
                return;
 
+       devlink_unregister(devlink);
        qed_fw_reporters_destroy(devlink);
 
        devlink_params_unregister(devlink, qed_devlink_params,
                                  ARRAY_SIZE(qed_devlink_params));
 
-       devlink_unregister(devlink);
        devlink_free(devlink);
 }