]> www.infradead.org Git - users/hch/misc.git/commitdiff
rtnetlink: Use register_pernet_subsys() in rtnl_net_debug_init().
authorKuniyuki Iwashima <kuniyu@amazon.com>
Tue, 1 Apr 2025 19:07:08 +0000 (12:07 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 3 Apr 2025 00:17:22 +0000 (17:17 -0700)
rtnl_net_debug_init() registers rtnl_net_debug_net_ops by
register_pernet_device() but calls unregister_pernet_subsys()
in case register_netdevice_notifier() fails.

It corrupts pernet_list because first_device is updated in
register_pernet_device() but not unregister_pernet_subsys().

Let's fix it by calling register_pernet_subsys() instead.

The _subsys() one fits better for the use case because it keeps
the notifier alive until default_device_exit_net(), giving it
more chance to test NETDEV_UNREGISTER.

Fixes: 03fa53485659 ("rtnetlink: Add ASSERT_RTNL_NET() placeholder for netdev notifier.")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250401190716.70437-1-kuniyu@amazon.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/rtnl_net_debug.c

index 7ecd28cc1c225672752e21a3bc408f492bdeb3ce..f3272b09c25568123b214213dffe42fb24d92a78 100644 (file)
@@ -102,7 +102,7 @@ static int __init rtnl_net_debug_init(void)
 {
        int ret;
 
-       ret = register_pernet_device(&rtnl_net_debug_net_ops);
+       ret = register_pernet_subsys(&rtnl_net_debug_net_ops);
        if (ret)
                return ret;