]> www.infradead.org Git - nvme.git/commitdiff
net: ethernet: mtk_eth_soc: revise QDMA packet scheduler settings
authorBo-Cun Chen <bc-bocun.chen@mediatek.com>
Wed, 16 Apr 2025 00:51:25 +0000 (01:51 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 17 Apr 2025 15:13:41 +0000 (08:13 -0700)
The QDMA packet scheduler suffers from a performance issue.
Fix this by picking up changes from MediaTek's SDK which change to use
Token Bucket instead of Leaky Bucket and fix the SPEED_1000 configuration.

Fixes: 160d3a9b1929 ("net: ethernet: mtk_eth_soc: introduce MTK_NETSYS_V2 support")
Signed-off-by: Bo-Cun Chen <bc-bocun.chen@mediatek.com>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Link: https://patch.msgid.link/18040f60f9e2f5855036b75b28c4332a2d2ebdd8.1744764277.git.daniel@makrotopia.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mediatek/mtk_eth_soc.c

index 5a3cfb8908a17e5fefbc70b86a38348facfd9ae9..bdb98c9d8b1c19c6927b0dc1890d011114b68356 100644 (file)
@@ -762,8 +762,8 @@ static void mtk_set_queue_speed(struct mtk_eth *eth, unsigned int idx,
                        break;
                case SPEED_1000:
                        val |= MTK_QTX_SCH_MAX_RATE_EN |
-                              FIELD_PREP(MTK_QTX_SCH_MAX_RATE_MAN, 10) |
-                              FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 5) |
+                              FIELD_PREP(MTK_QTX_SCH_MAX_RATE_MAN, 1) |
+                              FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 6) |
                               FIELD_PREP(MTK_QTX_SCH_MAX_RATE_WEIGHT, 10);
                        break;
                default:
@@ -3320,7 +3320,7 @@ static int mtk_start_dma(struct mtk_eth *eth)
                if (mtk_is_netsys_v2_or_greater(eth))
                        val |= MTK_MUTLI_CNT | MTK_RESV_BUF |
                               MTK_WCOMP_EN | MTK_DMAD_WR_WDONE |
-                              MTK_CHK_DDONE_EN | MTK_LEAKY_BUCKET_EN;
+                              MTK_CHK_DDONE_EN;
                else
                        val |= MTK_RX_BT_32DWORDS;
                mtk_w32(eth, val, reg_map->qdma.glo_cfg);