]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
tools/testing/selftests/vm/ksm_tests.c: fix resource leak when return error
authorDing Xiang <dingxiang@cmss.chinamobile.com>
Wed, 15 Jun 2022 09:36:29 +0000 (17:36 +0800)
committerLiam R. Howlett <Liam.Howlett@oracle.com>
Wed, 20 Jul 2022 00:15:07 +0000 (20:15 -0400)
When return on an error path, file handle need to be closed to prevent
resource leak

Link: https://lkml.kernel.org/r/20220615093629.1330809-1-dingxiang@cmss.chinamobile.com
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
tools/testing/selftests/vm/ksm_tests.c

index 2fcf24312da887130afe8d46d5332e5e9a0e8b0e..f5e4e0bbd081534b8e17bc3e936e198970e78c16 100644 (file)
@@ -54,6 +54,7 @@ static int ksm_write_sysfs(const char *file_path, unsigned long val)
        }
        if (fprintf(f, "%lu", val) < 0) {
                perror("fprintf");
+               fclose(f);
                return 1;
        }
        fclose(f);
@@ -72,6 +73,7 @@ static int ksm_read_sysfs(const char *file_path, unsigned long *val)
        }
        if (fscanf(f, "%lu", val) != 1) {
                perror("fscanf");
+               fclose(f);
                return 1;
        }
        fclose(f);