]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
staging: greybus: remove unnecessary GPIO line direction check
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 10 Jun 2025 15:20:36 +0000 (17:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Jun 2025 15:32:37 +0000 (17:32 +0200)
As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input
lines"), the GPIO core makes sure values cannot be set on input lines.
Remove the unnecessary check.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Rui Miguel Silva <rui.silva@linaro.org>
Link: https://lore.kernel.org/r/20250610152036.86099-1-brgl@bgdev.pl
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/gpio.c

index f81c34160f720b7dcb55b5f6acb9da890dbafce2..1280530c8987a3e958e0d501b29151aa552594c0 100644 (file)
@@ -192,12 +192,6 @@ static int gb_gpio_set_value_operation(struct gb_gpio_controller *ggc,
        struct gb_gpio_set_value_request request;
        int ret;
 
-       if (ggc->lines[which].direction == 1) {
-               dev_warn(dev, "refusing to set value of input gpio %u\n",
-                        which);
-               return -EPERM;
-       }
-
        request.which = which;
        request.value = value_high ? 1 : 0;
        ret = gb_operation_sync(ggc->connection, GB_GPIO_TYPE_SET_VALUE,