]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ASoC: max98088: Check for clk_prepare_enable() error
authorChen Ni <nichen@iscas.ac.cn>
Fri, 28 Jun 2024 08:05:34 +0000 (16:05 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 28 Jun 2024 12:39:31 +0000 (13:39 +0100)
clk_prepare_enable() may fail, so we should better check its return
value and propagate it in the case of error.

Fixes: 62a7fc32a628 ("ASoC: max98088: Add master clock handling")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Link: https://patch.msgid.link/20240628080534.843815-1-nichen@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/max98088.c

index 8b56ee550c09e2c784385ac10dd4c38d442a4434..8b0645c63462070d6d584c7d43d96d21f3dd6cfb 100644 (file)
@@ -1318,6 +1318,7 @@ static int max98088_set_bias_level(struct snd_soc_component *component,
                                   enum snd_soc_bias_level level)
 {
        struct max98088_priv *max98088 = snd_soc_component_get_drvdata(component);
+       int ret;
 
        switch (level) {
        case SND_SOC_BIAS_ON:
@@ -1333,10 +1334,13 @@ static int max98088_set_bias_level(struct snd_soc_component *component,
                 */
                if (!IS_ERR(max98088->mclk)) {
                        if (snd_soc_component_get_bias_level(component) ==
-                           SND_SOC_BIAS_ON)
+                           SND_SOC_BIAS_ON) {
                                clk_disable_unprepare(max98088->mclk);
-                       else
-                               clk_prepare_enable(max98088->mclk);
+                       } else {
+                               ret = clk_prepare_enable(max98088->mclk);
+                               if (ret)
+                                       return ret;
+                       }
                }
                break;