iio: sx9360: fix iio event generation

To convert SX9360 status register ["REG_STAT"], into a channel
index, we need to right shift by |stat_offset|, not left shift.
Also the PROXSTAT bit (3) is for channel 1 (PHM, Phase Measured), not (PHR,
Phase Reference, channel 0), so the offset is 2 instead of 3.

Fixes: 1cdb4c47f7f5 ("iio:proximity:sx9360: Add sx9360 support")
Signed-off-by: Jongpil Jung <jongpil19.jung@samsung.com>
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Link: https://lore.kernel.org/r/20220122213444.745152-1-gwendal@chromium.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/proximity/sx9360.c b/drivers/iio/proximity/sx9360.c
index 6fd6561bb6f5b8db478c5fe443a163037e950fb4..3ebb30c8a4f61d437f9a991e95cded21a34ddc07 100644 (file)
--- a/drivers/iio/proximity/sx9360.c
+++ b/drivers/iio/proximity/sx9360.c
@@ -775,7 +775,7 @@ static const struct sx_common_chip_info sx9360_chip_info = {
        .reg_reset = SX9360_REG_RESET,
 
        .mask_enable_chan = SX9360_REG_GNRL_CTRL0_PHEN_MASK,
-       .stat_offset = 3,
+       .stat_offset = 2,
        .num_channels = SX9360_NUM_CHANNELS,
        .num_default_regs = ARRAY_SIZE(sx9360_default_regs),
 

diff --git a/drivers/iio/proximity/sx_common.c b/drivers/iio/proximity/sx_common.c
index ac8fd5920481cb393498a7fc07f49139ff4fd6c8..a7c07316a0a91e9dd823b7b80182b4c97cb5a152 100644 (file)
--- a/drivers/iio/proximity/sx_common.c
+++ b/drivers/iio/proximity/sx_common.c
@@ -87,7 +87,7 @@ static void sx_common_push_events(struct iio_dev *indio_dev)
                return;
        }
 
-       val <<= data->chip_info->stat_offset;
+       val >>= data->chip_info->stat_offset;
 
        /*
         * Only iterate over channels with changes on proximity status that have